ytsaurus / ytsaurus-k8s-operator

Kubernetes operator for YTsaurus.
https://ytsaurus.tech
Other
35 stars 24 forks source link

Fix RELEASE_VERSION propagation to the image tag #337

Closed sgburtsev closed 1 month ago

sgburtsev commented 1 month ago

As mentioned in https://github.com/ytsaurus/ytsaurus-k8s-operator/pull/320#issuecomment-2338444497, I broke tag propagation with my changes in #320.

I verified that propagation with this fix works in this way:

RELEASE_VERSION=1.1.1 make helm-chart
helm template ytop-chart ytop-chart/ -s templates/deployment.yaml | grep image
        image: ytsaurus/k8s-operator:1.1.1
        image: gcr.io/kubebuilder/kube-rbac-proxy:v0.13.0

cc: @wilwell.

wilwell commented 1 month ago

I am surprised that you can just remove tag. I thought that values.yaml is generated file, not prewritten.

wilwell commented 1 month ago

cc @qurname2