search

ytsaurus / ytsaurus-k8s-operator

Kubernetes operator for YTsaurus.
https://ytsaurus.tech
Other
35 stars 25 forks source link

Enable tracing_mode = force in rpc_server configuration in HTTP and RPC proxies #62

Open Kontakter opened 12 months ago

Kontakter commented 12 months ago

I thinks it should be enabled for proxies by default. It is very useful for diagnostic purposes.

psushin commented 12 months ago

Why don't we do it in server code by default?

Kontakter commented 12 months ago

I think that we do not want to make this value as default for all services. But I am not confident about possible drawbacks.

psushin commented 12 months ago

It is quite possible to turn it on by default just for a specific component (or components). As a general rule - I prefer not to bloat static configuration created by operator with universally useful options - they should better be defaults in server code.

Kontakter commented 12 months ago

Sounds reasonable, let's do it!

l0kix2 commented 1 month ago

@Kontakter @psushin is it still an issue? If server code supports it already (or don't want yt operator to configure it in any case) we can close it. If it is make sense to have such default behaviour until supported in server side we can add some default value in ytop config gen and remove it later when it supported in server code