search

ytsaurus / ytsaurus-ui

Web interface for YTsaurus.
https://ytsaurus.tech
Other
37 stars 19 forks source link

Global table settings are not applied on the table page #784

Open Flunt1k opened 2 months ago

Flunt1k commented 2 months ago

If the user selects something in the global table settings (which are behind the gear in the navigation), they will never be used in the navigation/table page. Because on the table page the settings are taken from window.__DATA__, not from local storage.

vrozaev commented 1 month ago

Looks like opensource we write these settings to local storage, but we never read it back.

ma-efremoff commented 1 month ago

The behaviour depends on current instance of settings provider Please describe steps to reproduce the issue.

Flunt1k commented 2 weeks ago

Steps to reproduce:

  1. Open a static table in the navigation
  2. Change the table settings in the navigation sidebar (under the gear)
  3. Reload the page

After that, you will see that there are no changes to the table settings (related to the open table).

I assume the problem is due to the fact that the settings are always used from window.__DATA__, but not from localStorage.

https://github.com/ytsaurus/ytsaurus-ui/blob/f1a480a87f61fbd074e75cf311ce0de6572dc398/packages/ui/src/ui/store/reducers/navigation/content/table/table.js#L25 https://github.com/ytsaurus/ytsaurus-ui/blob/dfc8930d7925f4a6389cd6600f1ce165f2fb2852/packages/ui/src/ui/config/index.ts#L15 https://github.com/ytsaurus/ytsaurus-ui/blob/f910ed03c3f9671776c21b622df93b2e85be160d/packages/ui/src/ui/config/ui-settings.ts#L3