search

ytti / oxidized

Oxidized is a network device configuration backup tool. It's a RANCID replacement!
Apache License 2.0
2.79k stars 922 forks source link

Comware "carriage return" after display version 50% of the time #246

Closed travislikestocode closed 8 years ago

travislikestocode commented 8 years ago

Like the title suggests, every time Oxidized runs, all of my HP 5900 (comware) switches show either the addition or removal of a "carriage return" after the final comment after the output of display version. In a hex editor I see the following differences:

Before

20 0D 0A

After

20 0D 0D 0A

My HP 5820 doesn't do this. I'm not sure if this is a bug in oxidized or if the device actually has inconsistent output.

travislikestocode commented 8 years ago

I couldn't get the output to fluctuate manually, but I did manage to fix the issue in oxidized by stripping out carriage returns with:

.gsub(/\r/,"")

I'll create a pull request soon

ytti commented 8 years ago

Has there been PR?

ytti commented 8 years ago

closing due to inactivity, please reopen if needed