search

ytti / oxidized

Oxidized is a network device configuration backup tool. It's a RANCID replacement!
Apache License 2.0
2.74k stars 915 forks source link

Comments in CSV source #64

Closed andrewpwade closed 9 years ago

andrewpwade commented 9 years ago

Hey,

Thank you for this tool :)

I noticed that rancid supports comments in router.db (lines beginning with '#') but it doesn't seem to work in oxidized:

 E, [2014-12-12T15:25:21.900916 #3800] ERROR -- : node {:name=>"# comment"

I don't know ruby otherwise I'd send a PR. I guess it's a fairly small change?

Thanks

ytti commented 9 years ago

https://github.com/ytti/oxidized/commit/7c5d336aa0fbf8dc731eb1d88fb16c3d4b11a162

Should do the trick. Unfortunately I was planning to release 0.3.0 last weekish, but ran out of time, and now the repo has broken version. Hopefully I'll get around to release 0.3.0 before end of year.

andrewpwade commented 9 years ago

Awesome. Thank you!