search

yu-ming-chen / pe

0 stars 0 forks source link

Instantiating an interface #10

Open yu-ming-chen opened 3 years ago

yu-ming-chen commented 3 years ago

Model is an interface, ":Model" refers to an instance of an interface. However, interface canot be instantited, therefore, it should be ModelManager here. Screenshot 2020-11-13 at 5.18.29 PM.png

nus-se-bot commented 3 years ago

Team's Response

This issue is inherited from AB3, thus, this bug is rejected with its severity downgraded to VeryLow.

(with reference to https://github.com/nus-cs2103-AY2021S1/tp/blob/master/docs/DeveloperGuide.md)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team mentioned it is an issue inherited from AB3. According to the lecture it is stated that objects in sequence diagram are instances, therefore my team have changed it to ModelManager thinking that AB3's sequence diagram is wrong. AB3's error should not be used to justify the error in the diagram. Therefore, this should still be an wrong annotation in the sequence diagram.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This should at least be a low severity, imagaine developers looking at this diagram thinking that we instantiate an Mobel object which is not possible as it is an interface. They are not looking at your code base therefore will not know this information.