search

yu210148 / gvm_install

A script to install GVM 20 or 21 on Ubuntu 20.04 or Debian 10.
GNU General Public License v3.0
142 stars 71 forks source link

Incorrect variable name results version update fail. #80

Closed itiligent closed 2 years ago

itiligent commented 2 years ago

Hi, and thanks for your great work!

see line 218: sudo -Hiu gvm echo "cd /opt/gvm/gvm-libs-$GVM_VERSION" | sudo -Hiu gvm tee -a /opt/gvm/.bashrc

This line is a bit of an outlier in that is the only one in the pattern callig the wrong variable name. $GVM_VERSION above should be $GVM_LIBS_VERSION.

When using the script on 21.4.4 it still works due to the phasing of previous version numbers.

I found this when adapting the script to install 21.4.5. The only other changes to install 21.4.5 seem to be:

export GVM_VERSION=21.4.5
export GVM_LIBS_VERSION=21.4.4
export GVMD_VERSION=21.4.5
export GSA_VERSION=21.4.4
export OPENVAS_SMB_VERSION=21.4.0
export OPENVAS_SCANNER_VERSION=21.4.4
export OSPD_VERSION=21.4.4
export OSPD_OPENVAS_VERSION=21.4.4
export GSAD_VERSION=21.4.4
yu210148 commented 2 years ago

Thanks for the info I'll have a look next time I'm in front of my computer.

Kev.

On Tue, Jun 28, 2022, 12:20 PM itiligent @.***> wrote:

Hi, and thanks for your great work!

see line 218: sudo -Hiu gvm echo "cd /opt/gvm/gvm-libs-$GVM_VERSION" | sudo -Hiu gvm tee -a /opt/gvm/.bashrc

This line is a bit of an outlier in that is the only one in the pattern callig the wrong variable name. $GVM_VERSION above should be $GVM_LIBS_VERSION.

When using the script on 21.4.4 it still works due to the phasing of previous version numbers.

I found this when adapting the script to install 21.4.5. The only other changes to install 21.4.5 seem to be:

export GVM_VERSION=21.4.5 export GVM_LIBS_VERSION=21.4.4 export GVMD_VERSION=21.4.5 export GSA_VERSION=21.4.4 export OPENVAS_SMB_VERSION=21.4.0 export OPENVAS_SCANNER_VERSION=21.4.4 export OSPD_VERSION=21.4.4 export OSPD_OPENVAS_VERSION=21.4.4 export GSAD_VERSION=21.4.4

— Reply to this email directly, view it on GitHub https://github.com/yu210148/gvm_install/issues/80, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFY4PDRNH6KIXY2OI3ZZ3VRMQ5LANCNFSM52CYMN4A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

yu210148 commented 2 years ago

Thanks again, just committed the change on line 218.

kev.

On Tue, Jun 28, 2022 at 12:20 PM itiligent @.***> wrote:

Hi, and thanks for your great work!

see line 218: sudo -Hiu gvm echo "cd /opt/gvm/gvm-libs-$GVM_VERSION" | sudo -Hiu gvm tee -a /opt/gvm/.bashrc

This line is a bit of an outlier in that is the only one in the pattern callig the wrong variable name. $GVM_VERSION above should be $GVM_LIBS_VERSION.

When using the script on 21.4.4 it still works due to the phasing of previous version numbers.

I found this when adapting the script to install 21.4.5. The only other changes to install 21.4.5 seem to be:

export GVM_VERSION=21.4.5 export GVM_LIBS_VERSION=21.4.4 export GVMD_VERSION=21.4.5 export GSA_VERSION=21.4.4 export OPENVAS_SMB_VERSION=21.4.0 export OPENVAS_SCANNER_VERSION=21.4.4 export OSPD_VERSION=21.4.4 export OSPD_OPENVAS_VERSION=21.4.4 export GSAD_VERSION=21.4.4

— Reply to this email directly, view it on GitHub https://github.com/yu210148/gvm_install/issues/80, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFY4PDRNH6KIXY2OI3ZZ3VRMQ5LANCNFSM52CYMN4A . You are receiving this because you are subscribed to this thread.Message ID: @.***>