search

yuanners / pe

0 stars 0 forks source link

Unable to add overnight classes #13

Open yuanners opened 1 year ago

yuanners commented 1 year ago

Did not account for the case where some classes(eg zoom lesson for an overseas uni due to time difference) could be over night.

image.png

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Impossible time for deadline

For the school class task, if you put in the time 2400 (which does not exist), it will still see it as a time. Additionally, if you have the /from time before, then it will still not notice it as an error and the time for /to will technically be before the /from time.

image.png

image.png

[original: nus-cs2113-AY2223S2/pe-interim#2543] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

2400 is a valid time input and it is equivalent to 0000 which is why the first case is a valid input. That being said, for the second case our team agrees that whilst an edgecase, it is not unreasonable for an event to last till midnight. However, given that this is an edgecase for the user, whom will rarely input 2400 instead of 0000, we argue that the severity should be dropped to "Low" instead. We agree that it would be better to limit the time input to 2359 or remind the user to do so. therefore we believe it should be a feature flaw.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]