search

yuanqidu / LeftNet

50 stars 5 forks source link

The node frame has no effect in the code #6

Open e-yi opened 1 month ago

e-yi commented 1 month ago

https://github.com/yuanqidu/LeftNet/blob/326ad6d2c6f06a0300c7b98b7cdd97f7926e91fc/model.py#L208

It is used to compute scalrization in FTE, but scalrization does not contribute to any of the outputs.

e-yi commented 1 month ago

https://github.com/yuanqidu/LeftNet/blob/326ad6d2c6f06a0300c7b98b7cdd97f7926e91fc/model.py#L210

My guess is this line

scalar = torch.norm(vec1, dim=-2)

should be

scalar = torch.norm(scalrization , dim=-2)