yuanshuo / jupiter-eclipse-plugin

Automatically exported from code.google.com/p/jupiter-eclipse-plugin
0 stars 0 forks source link

Jupiter allows to add issues for files outside of reviewed files #86

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
When doing a review open any file in the project (that is not listed in
list of files for the review) and add an issue for it. 

What is the expected output? What do you see instead?
The expected output is either negative for adding an issue (error message
like: "This file is not being reviewed") or adding the file to the list of
reviewed files (maybe after additional confirmation).

Currently the issue is saved without any confirmation nor without adding
the file to the list of reviewed files.

What version of the product are you using? On what operating system?
Jupiter 3.5.0 on Windows XP.

Original issue reported on code.google.com by aleksand...@poczta.onet.pl on 31 Aug 2009 at 3:38

GoogleCodeExporter commented 9 years ago
I don't see this as a bug at all - but like it as a feature.  I'd be fine with 
the
suggestion of a confirmation, but please don't restrict the flexibility of the 
tool.

Thanks.

Original comment by rikker...@gmail.com on 18 Dec 2009 at 4:55

GoogleCodeExporter commented 9 years ago
It depends on the review process one has established in one's organization.

I'd prefer to have an option to restrict the list of reviewed files -- as I'd 
like
the reviewer to focus only on selected files, not just wander through the code.

So the message to Jupiter Project Contributors should be: is it possible to 
enable
flag 'Issues restricted only to selected files'?
This way both user groups ('flexibles' and 'stricties') would be satisfied...

Original comment by aleksand...@poczta.onet.pl on 18 Dec 2009 at 8:54