search

yuanshuo / jupiter-eclipse-plugin

Automatically exported from code.google.com/p/jupiter-eclipse-plugin
0 stars 0 forks source link

No diff function #87

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi, I found that there is no diff function (Such as 'Diff with previous
version' function in SVN). I think this function is very useful and will
add it into the new version of jupiter?

Original issue reported on code.google.com by james31...@gmail.com on 2 Sep 2009 at 4:05

GoogleCodeExporter commented 9 years ago 
What do you need the diff function for? I'm a little confused.

Do you want an utility that helps you merge issues from different 
reviewerw/reviews?

Or do you want to add issues while browsing through the diff between two 
versions of
file?

Original comment by aleksand...@poczta.onet.pl on 2 Sep 2009 at 7:46

GoogleCodeExporter commented 9 years ago 
What I mean is the latter：‘add review issues while browsing through the 
diff between
two versions of file’. Is this already afford in the Jupiter?
Besides, is that possible to add an filtering function in the 'Review File 
Selection'
window when create a new Review ID(file),because in that window, all kinds of
files(such as .project, .svn,.java,etc) are list, which looks like a bit 
messing. So,
if there is a filtering field and I can input some rule expression languages, 
such as
'*.java' and it list all .java files then I can choose what I like to review, 
it will
be better!

Original comment by james31...@gmail.com on 26 Oct 2009 at 2:02

GoogleCodeExporter commented 9 years ago 
When reviewing a file, the diff function would be nice because you don't want 
to weed
through already reviewed code to see the 3 lines of code that has been changed.

The diff function would alert the reviewer of the exact files to be reviewed.

Original comment by chasidym...@gmail.com on 13 Nov 2009 at 3:37

GoogleCodeExporter commented 9 years ago 
This is actually a very interesting feature request. The newly added code is 
always error-prone especially when 
there is no appropriate test suite. However, the catch is that the SCM could be 
subversion, cvs or Clearcase.

Original comment by hongb...@gmail.com on 28 May 2010 at 5:38

GoogleCodeExporter commented 9 years ago 
The type of review that is being talked about here is a diff based review, 
which I don't think was considered when Jupiter was originally being built.  
That is the type of review that ReviewBoard does.  It is usually meant to only 
review the last set of changes made and not review the entire class/code as a 
whole (although it doesn't stop you from writing anywhere in the modified files 
either).

There are many other hurdles that we'd have to clear before we can even 
consider doing this IMHO.  Sometimes a diff based review is good though, just 
focusing on small sections that have changed.

Original comment by jsakuda on 25 Jun 2010 at 8:41