yuanxi1 / pe

0 stars 0 forks source link

Duplicate detection is case sensitive #5

Open yuanxi1 opened 1 year ago

yuanxi1 commented 1 year ago

Adding three entries with everything the same except for the capitalisation of the name is allowed. Screenshot 2022-11-11 at 16.34.41.png

However, they are very likely to refer to the same person.

explanation for medium severity:

On website: Screenshot 2022-11-11 at 16.36.43.png

Considering this is a surveyee tracking app that requires users to manually type in all the data, it can occasionally happen that the user input some surveyee he/she has already input before with a different name capitalisation, this can make tracking messy.

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate detection for names with different cases

Steps to reproduce

Add the following commands 1) add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/male b/1998-11-28 ra/Chinese re/Christian s/Shopping survey t/friends t/owesMoney

2) add n/john doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/male b/1998-11-28 ra/Chinese re/Christian s/Shopping survey t/friends t/owesMoney

Expected

Prevent the user from entering the person twice. This is because the user with the same spelling and all the same attributes is probably a duplicate.

Actual

Both john doe's are added

Screenshots

image.png


[original: nus-cs2103-AY2223S1/pe-interim#1304] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: The team did not provide reason for lowering the severity. Reiterating my justification in the original bug report:

Considering this is a surveyee tracking app that requires users to manually type in all the data, it can occasionally happen that the user input some surveyee he/she has already input before with a different name capitalisation, this can make tracking messy.

Screenshot 2022-11-16 at 15 16 24

It is also mentioned here that such limitation should be made clear to the user. However, in the UG this is not very clear.

Screenshot 2022-11-16 at 15 18 17