search

yuanyan / halogen

A collection of loading spinners with React.js
https://yuanyan.github.io/halogen
MIT License
1.6k stars 151 forks source link

Webpack and others #1

Closed steida closed 9 years ago

steida commented 9 years ago

I am not sure it's ok to distribute jsx files, webpack can't recongize it by default and I suppose we should not have to BabelScriptize node.js code. It would quickly escalate into super long and brittle builds.

steida commented 9 years ago

Anyway, very nice work.

yuanyan commented 9 years ago

@steida Thxs

tajo commented 9 years ago

+1, it doesn't work with browserify & babelify

import {PulseLoader} from 'halogen';

Error : Cannot find module 'reactify' from '/Users/.../node_modules/halogen'

Obviously, I don't have reactify module in my project (just babelify), but I am not quite sure, why browserify&babelify can't handle the build.

Anyway, it's a good idea to commit the all-in one browserified file without JSX and use it as the main file.

yuanyan commented 9 years ago

@tajo Added reactify as dependencies, is it ok in halogen@0.1.4?

tajo commented 9 years ago

@yuanyan It is. Thanks! I really like this lib.

aybarshazar commented 9 years ago

I got the same error from the latest version (0.1.8) and had to downgrade to 0.1.4 to make it work with browserify.