search

yuanyan / halogen

A collection of loading spinners with React.js
https://yuanyan.github.io/halogen
MIT License
1.6k stars 151 forks source link

reactify moved from devDeps to deps #9

Open tajo opened 9 years ago

tajo commented 9 years ago

Reactify must be in normal deps, otherwise it doesn't work properly if your project build process is different (for example, I'm using babelify transformation instead of reactify).

Error : Cannot find module 'reactify' from '/Project/node_modules/halogen'

We already discussed that in https://github.com/yuanyan/halogen/issues/1 and you put it back. The other solution is to point package's main to bundled version.

tajo commented 9 years ago

Oh, it was already solved here: https://github.com/yuanyan/halogen/pull/8 and it came back. :-)

yuanyan commented 9 years ago

@tajo It is javascript source now when you install from npm, still need config reactify to dependencies?

tajo commented 9 years ago

Yep, I do. The problem is caused by:

  "browserify": {
    "transform": [
      "reactify"
    ]
  },
  "browserify-shim": {
    "react": "global:React"
  },

When I delete it, it works.

ascrazy commented 9 years ago

This problem still actual. Maybe it will be better to remove browserify config from package.json and specify transforms in gulpfile directly?

ascrazy commented 9 years ago

Oh, I saw that transforms already specified in gulpfile.js, so I believe it is no longer needed in package.json.

SebT commented 9 years ago

+1

iandoe commented 9 years ago

Hey, i am still getting this error, using react 0.14 and halogen 0.1.10. Any pointers ?

tajo commented 9 years ago

Well, reactify is based on react-tools which were deprecated since June and are completely removed in React 0.14.0. The official JSX transformer is Babel now. So this lib is broken. You can fork it if @yuanyan will not fix it or just copy&paste needed parts (my solution since all I really needed was just one loader).