yuanzhoucq / Tab-Space

A Safari extension born for improving your web browsing productivity.
https://mytab.space
101 stars 15 forks source link

[BUG] Tab Space struggles to maintain it's pinned tab position when activated, unlike Onetab #102

Open jpfsh opened 1 year ago

jpfsh commented 1 year ago

Describe the bug Tab space fails to maintain itself as a pinned tab when tabs are brought in. It also doesn't start out as pinned when safari itself is started. Onetab does this, and it allows quick reference/opening of it's tabs from there.

To Reproduce Steps to reproduce the behavior:

  1. Open some random tabs, then bring all tabs into tab space.
  2. Firstly, the resulting Tab Space tab should preferably be pinned.
  3. Pin Tab space, then close current safari window, or open a new one
  4. The tab space tab is now lost
  5. Alternatively: repeat and pin tab space, then open more tabs and invoke tab space again, and notice that a duplicate tab space tab has appeared. I'd preferably want the already pinned tab space to be the "base of operations"

Expected behavior Use onetab as a comparison point. When pressing the onetab button, all tabs are brought in, except for the onetab page (because it's pinned). Tab space's page isn't brought in either, but it's not pinned. This is important because pinned tabs aren't lost when safari windows are closed, and are also "duplicated" for each safari window instance. Even if I try to pin the Tab Space page, it doesn't have a similar persistence as onetab's pinned behavior.

Screenshots N/A

Desktop (please complete the following information):

Additional context One thing onetab is better at, is how it reliably pins itself all the time, regardless of me closing a window, restarting safari, etc. Pinned tabs for an app like this can be important because of quicker/easier access via keyboard, for example. Right after sending all tabs to Onetab, I can cmd+w then cmd+n again, and onetab is still there, pinned.