[BUG] Key presses from previously focused app are captured by Tab Space - Githubissues

yuanzhoucq / Tab-Space

A Safari extension born for improving your web browsing productivity.

https://mytab.space

101 stars 15 forks source link

[BUG] Key presses from previously focused app are captured by Tab Space #48

Open gingerbeardman opened 3 years ago

gingerbeardman commented 3 years ago

Describe the bug Key presses from previously focused app are captured by Tab Space

To Reproduce Steps to reproduce the behavior:

Use Safari
Switch to Mini vMac app
press Control+Q to quit Mini vMac, key-down event lands on Mini vMac
Safari comes back into focus
At this point I am still releasing the Q key, key-up event will land on Safari
Tab Space responds by closing tabs!

Expected behavior

should only capture key presses that originated with Safari focussed

Desktop (please complete the following information):

OS: macOS 10.14.6
Version 3.8.2

Additional context

Screen recording: https://imgur.com/a/jKMjMSl

Workaround

If I do an unnaturally quick key press I can avoid the issue

or

Change Tab-Space shortcut to Control+Shift

Thoughts

perhaps responding on key down rather than key up would be enough?

Also see #47