search

yuanzhoucq / Tab-Space

A Safari extension born for improving your web browsing productivity.
https://mytab.space
100 stars 14 forks source link

[BUG] "Save & Close Tabs" leaves the last tab open if tab space page is in the tabs #71

Open znculee opened 2 years ago

znculee commented 2 years ago

Describe the bug A clear and concise description of what the bug is. It should be expected that after clicking "Save & Close Tabs", all tabs should be closed. However, if the tab space page is on, the last tab will not be closed as expected. The similar extension "one tab" doesn't have this issue.

To Reproduce Steps to reproduce the behavior:

  1. Open tab space page.
  2. Restore and delete a set of tabs without manually close the tab space page.
  3. Click on "Save & Close Tabs".
  4. The last tab will not be closed, even though it should be saved successfully.

Desktop (please complete the following information): Mac OS 11.6

yuanzhoucq commented 2 years ago

Thanks for the bug reporting.

Normally in this situation, the extension will activate the Tab Space page and close other tabs. But now the SFSafariTab.activate(completionHandler:) method stops working. It seems to be a bug of Safari. I will file this bug and think about an alternative way to solve this issue. 😄