Build on OpenJDK 7 is broken

[GoogleCodeExporter]

What steps will reproduce the problem?
0. svn checkout
1. cd java
2. ant

~/sfntly-read-only/java$ java -version
java version "1.7.0_25"
OpenJDK Runtime Environment (IcedTea 2.3.10) (7u25-2.3.10-1ubuntu0.12.04.2)
OpenJDK 64-Bit Server VM (build 23.7-b01, mixed mode)

~/sfntly-read-only/java$ ant
Buildfile: /sfntly-read-only/java/build.xml

compile:
    [javac] Compiling 201 source files to /sfntly-read-only/java/build/classes
    [javac] /sfntly-read-only/java/src/com/google/typography/font/sfntly/table/opentype/component/VisibleBuilder.java:8: error: Builder has protected access in SubTable
    [javac]   class VisibleBuilder<T extends SubTable> extends SubTable.Builder<T> {
    [javac]                                                            ^
    [javac] /sfntly-read-only/java/src/com/google/typography/font/sfntly/sample/sfview/RuleDump.java:26: error: method charGlyphClosure in class Rule cannot be applied to given types;
    [javac]     GlyphGroup ruleClosure = Rule.charGlyphClosure(txt, font);
    [javac]                                  ^
    [javac]   required: Font,String
    [javac]   found: String,Font
    [javac]   reason: actual argument String cannot be converted to Font by method invocation conversion
    [javac] /sfntly-read-only/java/src/com/google/typography/font/sfntly/table/opentype/component/VisibleBuilder.java:20: error: method does not override or implement a method from a supertype
    [javac]     @Override
    [javac]     ^
    [javac] /sfntly-read-only/java/src/com/google/typography/font/sfntly/table/opentype/component/VisibleBuilder.java:23: error: method does not override or implement a method from a supertype
    [javac]     @Override
    [javac]     ^
    [javac] /sfntly-read-only/java/src/com/google/typography/font/sfntly/table/opentype/component/VisibleBuilder.java:26: error: method does not override or implement a method from a supertype
    [javac]     @Override
    [javac]     ^
    [javac] /sfntly-read-only/java/src/com/google/typography/font/sfntly/table/opentype/component/VisibleBuilder.java:29: error: method does not override or implement a method from a supertype
    [javac]     @Override
    [javac]     ^
    [javac] 6 errors

BUILD FAILED
/sfntly-read-only/java/common.xml:21: Compile failed; see the compiler error 
output for details.

Total time: 12 seconds

Original issue reported on code.google.com by ebrami...@gmail.com on 18 Jan 2014 at 8:36

[GoogleCodeExporter]

Fixed locally by making SubTable.Builder public on SubTable.java and changing 
Rule.charGlyphClosure(txt, font) to Rule.charGlyphClosure(font, txt) on 
RuleDump.java

Original comment by ebrami...@gmail.com on 18 Jan 2014 at 8:53

[GoogleCodeExporter]

Same issue on Win 7 64bit

java version "1.8.0-ea"
Java(TM) SE Runtime Environment (build 1.8.0-ea-b108)
Java HotSpot(TM) 64-Bit Server VM (build 25.0-b50, mixed mode)

Changes mentioned in #1 worked fine. Thanks for sharing.

Original comment by jan.toso...@gmail.com on 27 Jan 2014 at 8:19

[GoogleCodeExporter]

Original comment by stua...@google.com on 28 Jan 2014 at 11:15

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in: https://codereview.appspot.com/57690047/

Original comment by c...@google.com on 26 Feb 2014 at 12:48

• Changed state: Fixed