search

yubaoquan / tree-view-git-branch-fix

Atom package, copied from tree-view-git-branch and fix its bugs.
MIT License
2 stars 0 forks source link

Location option : only top work #1

Closed camlafit closed 6 years ago

camlafit commented 6 years ago

Hi

Thanks to have patch/fork this project :)

I've found an issue, only location top is working. Inside or before don't display anything.

yubaoquan commented 6 years ago

I triggered this bug. This bug will happen only when you open more than one projects in a window.

I used to open one project in each window, so didn't found this bug before.

Thank you to reporting this bug, I will try to fix it.

yubaoquan commented 6 years ago

OK, fixed. Please update the package. Tell me if the bug happens again.

camlafit commented 6 years ago

Hello

Just updated to 0.3.1, but not working. Only top mode is ok. To be sure I've restart atom after settings change.

Indeed I use many projects on same working space. I use https://atom.io/packages/project-viewer to manage them.

Thanks

yubaoquan commented 6 years ago

I installed the project-viewer but not trigger the bug.

Can you find the error log in console? (click View->Developer->Toggle Developer Tools)

You can also use package-cop to locate which package caused the bug.

If make sure the bug is caused by using project-viewer, please tell me your setting of that package (click atom -> config and find config of project-viewer in config.cson)

camlafit commented 6 years ago

Hello

I get these errors : 

fail in initialize TypeError: Cannot read property 'parentNode' of null
    at Object.insertBefore (repository.js [sm]:115)
    at Object.<anonymous> (repository.js [sm]:33)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7
    at Object.update (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7)
    at Object.<anonymous> (repository.js [sm]:7)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7)
Uncaught (in promise) TypeError: Cannot read property 'classList' of null
    at Object.setSeparator (repository.js [sm]:105)
    at main.js [sm]:169
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/main.js:7)

I could do any test required :)

yubaoquan commented 6 years ago

This error log can only offer the information that the inject point is missing. I have no idea on what stuff make the inject point missing.

I'm not sure the bug is related to the package-viewer. You can disable the package-viewer package and restart atom to see if the bug is still happening. If you make sure the bug is related to package-viewer, please tell me the config data of it, as I mentioned in the last post.

In addition, what is package-viewer used for? I found I can only add some nested items in that panel, expanding and collapsing them. Is that all? Is it only a note panel?

camlafit commented 6 years ago

Hello

Just tried. I've disabled project-viewer and restart atom. Bug occurs again. My complete console log follows.

About project-viewer is a nice project manager, you can group (sub)projects in workspace and switch between from this panel. Each workspace context (file opened, ,new file, ...) are backup / reestablish during switch. ( https://github.com/jccguimaraes/atom-project-viewer ) 

IntersectionObserver.observe(target): target element is not a descendant of root.
TreeView @ <embedded>:119290
nuclicons.ttf Failed to load resource: net::ERR_FILE_NOT_FOUND
~/.atom/packages/adwaita-pro-ui/lib/adwaita-pro-ui.coffee:47 Loading adwaita-pro-ui...
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41 fail in initialize TypeError: Cannot read property 'parentNode' of null
    at Object.insertBefore (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:136:11)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:52:22)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:443
    at Object.update (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:99)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:22:24)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
(anonymous) @ ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41 fail in initialize TypeError: Cannot read property 'parentNode' of null
    at Object.insertBefore (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:136:11)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:52:22)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:443
    at Object.update (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:99)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:22:24)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
(anonymous) @ ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41 fail in initialize TypeError: Cannot read property 'parentNode' of null
    at Object.insertBefore (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:136:11)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:52:22)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:443
    at Object.update (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:99)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:22:24)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
(anonymous) @ ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41 fail in initialize TypeError: Cannot read property 'parentNode' of null
    at Object.insertBefore (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:136:11)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:52:22)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:443
    at Object.update (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:99)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:22:24)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
(anonymous) @ ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41 fail in initialize TypeError: Cannot read property 'parentNode' of null
    at Object.insertBefore (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:136:11)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:52:22)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:443
    at Object.update (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:99)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:22:24)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
(anonymous) @ ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41 fail in initialize TypeError: Cannot read property 'parentNode' of null
    at Object.insertBefore (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:136:11)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:52:22)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:443
    at Object.update (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:99)
    at Object.<anonymous> (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:22:24)
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:7:273)
(anonymous) @ ~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:41
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:147 Uncaught (in promise) TypeError: Cannot read property 'classList' of null
    at Object.setSeparator (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:126:33)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/main.js:166:40
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/main.js:7:273)
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:147 Uncaught (in promise) TypeError: Cannot read property 'classList' of null
    at Object.setSeparator (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:126:33)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/main.js:166:40
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/main.js:7:273)
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:147 Uncaught (in promise) TypeError: Cannot read property 'classList' of null
    at Object.setSeparator (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:126:33)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/main.js:166:40
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/main.js:7:273)
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:147 Uncaught (in promise) TypeError: Cannot read property 'classList' of null
    at Object.setSeparator (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:126:33)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/main.js:166:40
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/main.js:7:273)
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:147 Uncaught (in promise) TypeError: Cannot read property 'classList' of null
    at Object.setSeparator (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:126:33)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/main.js:166:40
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/main.js:7:273)
~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:147 Uncaught (in promise) TypeError: Cannot read property 'classList' of null
    at Object.setSeparator (~/.atom/packages/tree-view-git-branch-fix/lib/repository.js:126:33)
    at ~/.atom/packages/tree-view-git-branch-fix/lib/main.js:166:40
    at Generator.next (<anonymous>)
    at step (~/.atom/packages/tree-view-git-branch-fix/lib/main.js:7:273)
yubaoquan commented 6 years ago

Are you using atom in windows? I triggered this bug in windows today, finding the structure of tree-view is different from it is in OSX.

Upgrade the package to 0.3.2 please.

Tell me if the bug is still there.

yubaoquan commented 6 years ago

If you are using OS other than window and OSX, I cannot help, cause I don't have that devices 😆

camlafit commented 6 years ago

Sniff :/

I've updated and no change. Indeed I don't use neither Windows, neither OSX. I use Debian Stretch.

I can do any tests required but I cannot help about dev I don't understand anything about this :)

yubaoquan commented 6 years ago

Just updated again, I found another case will trigger the bug. If what you are opening is a link to the project folder, no matter soft link or hard link, the bug will happen. Because we locate the project root by its git repo path, but in the link folder, the path will not equal to the repo path.

Are you in this use case? If yes, you can only set the location to top before I found a real workaround to solve this issue.

camlafit commented 6 years ago

Hello

I've updated and enabled it. I've got an error message about "project root not found". But it's too fast to read all and use click action.

In mine workspaces (simple) uses case I've : first workspace

second workspace

yubaoquan commented 6 years ago

Hi, bug in link project has been fixed, please upgrade the package.

If bug happen again, please copy the variable log from the modal shown in atom and paste here.

Good luck!

camlafit commented 6 years ago

Hello

Just updated and sorry open an issue :/ And no evolve about this issue

camlafit commented 6 years ago

Hello

My pasted log follows

To note :

About projects :

yubaoquan commented 6 years ago

Updated again, version v0.3.6. I guess this time there's more than 50% possibility the bug is fixed.

camlafit commented 6 years ago

Yes :)

Looks better, I've now a git switcher inside each project but #3

camlafit commented 6 years ago

Hello

Thanks a lot, looks ok now. Inside mode is displayed as wanting. Before mode looks ok also

yubaoquan commented 6 years ago

Thank you for being so patient. Welcome for more issues and feature requests.

camlafit commented 6 years ago

Thanks you to have try and solve this problem. The easier is to open issue not to solve it :)