search

yubin-park / hccpy

A Python implementation of Hierarchical Condition Categories
Apache License 2.0
97 stars 59 forks source link

Update new version 28 #60

Closed hadarco87 closed 1 year ago

hadarco87 commented 1 year ago

Two things I recommended to do before merging this PR:

  1. We may need to pull from the external package into our fork.
  2. After that, we need to check that the last and only commit (Ron did) - still exists in our logic (https://github.com/Navina-ai/hccpy/commit/2bd77210298fec1ba8484c84f71cbe8948b46d5b)
  3. We Need to check if this file ("label_short": "data/V24_label_short.json") is something that is necessary - existing only for V24. Not exists for V28 (Maybe we can get it easily...
yubin-park commented 1 year ago

@hadarco87 thanks for the PR. However, your branch may need to be rebased with the latest master branch. Best,