path provided, yet "The field [path, location or contents] is required."

yuch7 / cwlexec

A new open source tool to run CWL workflows on LSF

Other

36 stars 8 forks source link

path provided, yet "The field [path, location or contents] is required." #3

Closed mr-c closed 6 years ago

mr-c commented 6 years ago

https://ci.commonwl.org/job/cwlexec/8/testReport/conformance_test_v1/0/Test_dynamic_resource_reqs_referencing_the_size_of_Files_inside_a_Directory/

From a new conformance test: https://github.com/common-workflow-language/common-workflow-language/pull/690/files

mr-c commented 6 years ago

Maybe the error is due to the Directory literal? https://github.com/common-workflow-language/common-workflow-language/pull/690/files#diff-ce2c77e84e9e514f9769b40221fc81d6R3

liuboxa commented 6 years ago

We used same way to parse the CWL file and directory, but, follow the specification, they are different, especially, when the path or location is not defined, for file, we should check contents, and for directory, we should check listing. Now we corrected them, see fa4962f