search

yuchangyuan / node-red-contrib-roomba980-fw2

Roomba 980(v2 firmware) support for nodered
Apache License 2.0
2 stars 5 forks source link

Encrypt credentials #3

Open IanStorm opened 4 years ago

IanStorm commented 4 years ago

Hey, I just included this node in my personal Node-RED flow; it works like a charm. 👍 One thing I saw however: The credentials are stored as plain text in the flows.json file. I think they should be stored inside flows_cred.json, with the advantage of auto-encryption/-decryption done by Node-RED. So far I don't have experience in creating nodes for Node-RED... I was thinking to give it a try and create a PR to fix that issue. Is this repo still active? Thanks in advance.

yuchangyuan commented 4 years ago

PR is welcome. I am not javascript developer, and currently I do not have enough time to work on this project.

And you can also fork this repo and submit npm, to make you forked node searchable from node-red instance.

IanStorm commented 4 years ago

Thanks for your reply. I also thought about forking the repo, but definitely prefer to first try to fix it here. (Plus, I didn't want to create another fork of a fork.) I value your precious time, and I am trying to provide a PR soon.

yuchangyuan commented 4 years ago

Beside not have enough time, another reason I not interest in this feature personally is that I use environment variable to refer the password, which injected by kubernetes.

Actually, credential should store in flow_cred.json, and I am looking forward for your PR.