yuche / vue-strap

Bootstrap components built with Vue.js
http://yuche.github.io/vue-strap/
MIT License
4.71k stars 929 forks source link

Vue 2.0 - ( for vue 2 check wffranco/vue-strap ) #250

Open dansullivan86 opened 8 years ago

dansullivan86 commented 8 years ago

Has any progress been made on getting this ready for Vue 2.0?

therealmarv commented 8 years ago

I tried to run the vue-strap homepage with Vue 2.0. It's not a lot of errors in the console there but it still does not work. This definitely needs more attention (use branch next of vue) because every important library like vuex, vue router is already step by step updated and we need a reliable UI library which works with vue's 2.0 VirtualDOM.

image

ubergarm commented 8 years ago

No luck here either. I was able to suppress the errors about templates by using the standalone build (which is not the default in Vue 2.0) by setting this in my webpack.base.js:

resolve: {
    alias: {vue: 'vue/dist/vue.js'}
},

https://github.com/vuejs/vue/wiki/Vue-2.0-RC-Starter-Resources

Then I can import like so:

import { popover } from 'vue-strap/dist/vue-strap.min.js'

But things don't render correctly or throw errors.

I'd love a nice type ahead widget in Vue 2.0!!!

Thanks

wffranco commented 8 years ago

Nothing about vue 2.0 right now. @therealmarv watching the capture I think I can help you to solve it, but first try to update vue-strap to the last version and test again.

niallobrien commented 8 years ago

If you're moving to Vue 2.0, it might be worth moving to Bootstrap 4 while you're at it imo.

wffranco commented 8 years ago

I tested with vue 2.0.0-rc.4 and have not errors, so I don't know is you are working with a old version of vue-strap. I pull a new branch: https://github.com/wffranco/vue-strap/tree/vue2

@niallobrien I probably will do this too, want to change to bootstrap 4

wffranco commented 8 years ago

I mean that I have no errors enabling vue 2.0, but obviously need to much to change. If you wanna help me you're welcome.

https://github.com/vuejs/vue/issues/2873

Greeting.

ropeladder commented 8 years ago

I've been poking around trying to get vue-strap to work with 2.0 with a few components. There some straightforward things like changing $els to $refs and v-el: to refs=. I'm running into a lot more trouble with the new <slot> behaviors, since slots can only be used once. This means that some template structures that are commonly used in vue-strap no longer work. E.g.

<label v-if="buttonStyle">
  <slot></slot>
</label>
<div v-else>
  <slot></slot>
</div>
wffranco commented 8 years ago

Really? That sounds like a bunch of problems in some components...

EDIT: I had not read all the features. I guess with templates or something else to do that kind of things.

niallobrien commented 8 years ago

Will it take a lot of work to get this ready for Vue 2.0 and Bootstrap 4?

wffranco commented 8 years ago

I think is an easier work to change to bootstrap 4. Change to vue 2 will need a lot of work, so maybe right now I will let the vue2 branch for later.

ropeladder commented 8 years ago

Note that the 'new slot behaviors' I mentioned above were actually a bug in 2.0rc ^4. With rc5 it looks like slots should work (without error messages) within v-if/v-else blocks: https://github.com/vuejs/vue/issues/3595

niallobrien commented 8 years ago

So are we on track? Does anyone have a good fork we can all work on with the hope of getting it merged in?

probil commented 8 years ago

There is vue-migration-helper. So, it can help with migration to vue 2.0

happilymarrieddad commented 8 years ago

Hey guys, thanks so much for all your hard work. +1 for working with Vue 2 for me as well. Thanks!

santigarcor commented 8 years ago

Vue 2.0 has been released so i think it would be great if someone starts working in a vue-strap 2.0

Kristjan-Reinsberg commented 7 years ago

I thought I love my girlfriend, but actually i love Vue2 + Vuestrap