Vuejs 2.0 Migration

[Humeira]

I have started working on migrating vue-strap to vue 2.0, I'll be grateful if someone can create a new branch v2 here.

Some folks have show interest in migrating to 2.0 as well https://github.com/yuche/vue-strap/issues/372 https://github.com/yuche/vue-strap/issues/374

[wffranco]

i make a fast change in the select. removed onblur nodelist event, and used a new directive. @druppy test it if you can. going late to work 🤓

[wffranco]

🦀 have some errors, this branch was created over the yuche v2 instead of vue2 like I think (local) and now have conflict... wait until i fix it

[wffranco]

Fixed.

[druppy]

@wffranco Select works really nice now, it hides selections as expected !

[webnoob]

So, are you guys working on v2 now instead of vue2 branch?

[druppy]

@webnoob yeps @wffranco's fork and the v2 branch. As I understand it, this was to harmonize the branch name with the original repos, and make PR more straightforward.

[webnoob]

Ah, ok. Thanks. I'll pull it later and see how the new selects work :)

[wffranco]

Affix now work fine.

@druppy , the most of the things that need changes is for twoway binding or modify properties inside the component. I think that the properties must be closer to vue1 version, so try to do that:

• create a new variable in the component data (e.g. for property value, create variable val in data)
• add a watcher to the property that update the variable.
• add a watcher to the variable that emit an event with the new value
• in the specific case of value (for v-model binding) remember to emit input event

On input/select components you can see that.

[wffranco]

Typeahead fixed.

• async typeahead need some adjustment for lazy loads, but the old functionality is done.

[druppy]

@wffranco Affix works here too, nice.

Panel isOpen fixed, alert doc duration fix, and very basic typescript support.

[druppy]

Checkbox + docs works, carousel has no more warning, not sure how the indicators should have worked :-)

We have changed checked prob to Boolean but the emitted event is value or null, is this what we want ?

[wffranco]

I saw that you added typings to the project....

What is it used for?

[druppy]

Typings are new to TS 2 and makes it possible to include typescript definitions in npm for seamless integration, see this.

vue, vue-router and vue-class-component all have this, and combined with npm @typings we can now enjoy typescript in a pure npm setup :-)

[wffranco]

merged v2 branch. set the version to 2.0.0-pre.1 Still need some fixes but working the most. I stablished vue2 as master in my fork.

[druppy]

Ok, looks really good, thanks for all the hard work.

Do you have any idea as to when vue-strap will pull in you changes and officially support Vue2 ?

[webnoob]

@wffranco Really appreciate all the work you've put in. Thanks. @druppy That goes for you as well!

[FerchoCarcho]

if Npm it will it bring the v.2?

[webnoob]

@FerchoCarcho No, you need to pull / download the build version from @wffranco source.

https://github.com/wffranco/vue-strap/tree/master

[webnoob]

@druppy With regards to your comment about making this being merged into the main vue-strap brance and support vue2, I think we're still a little ways off that. There are still a number of warnings being raised when using the components (i.e Datepicker warns about mutating props directly) and also raises an error about window.eventlistener.

There are some other issues as well but thought I'd note here so people don't think it's production ready just yet.

[druppy]

@webnoob I am aware of this, but I guess @wffranco are cleaning up details now, and prepares for the final PR :-) I am just using the fork as a local clone (v2 branch), until a release happens :-)

[webnoob]

@druppy Yeah understandable, given that @FerchoCarcho already asked about using this I thought it wise to make sure it's clear it's not production ready just yet :) Close though! :P

[wffranco]

Yuche has been inactive for several months, so at the moment I prefer to work on my branch and update eventually over the yuche/v2 branch. @druppy like I said the last time, I'm working over my master branch, so if you're changing something please try to do it there or notify me to merge 😃

[druppy]

@wffranco I will switch from v2 to master branch in your fork, I was just confused ... again :-) Anyway, it begins to look really good now, except for small details.

[Humeira]

@wffranco he replied on this thread like a month ago, maybe another ping @yuche !

Thanks for the work!! 🎉

[mediaessenz]

@wffranco could you please active issue tracker inside your fork? This would make collaboration easier 😄

[wffranco]

done 👍

[otabekgb]

This repository seems to have stuck. Community should move to wffranco. How can we inform the whole community?

[purepear]

@druppy @wffranco about Datepicker https://github.com/wffranco/vue-strap/issues/8 https://gist.github.com/purepear/df5fb8a6cc862071bb07ca5d059a0ade

[neilsmind]

@wffranco - Really appreciate your effort to move things forward to v2. Noticed that you merged v2 as a branch into this repo in March.

Given that your project was merged back here, no further commits have been made there since then and you're a collaborator on this repository, does this repo remain core for vue-strap and, more importantly, v2?

We're using vue-strap within a project and I'm happy to contribute / collaborate...just trying to figure out where. :-)