search

yuche / vue-strap

Bootstrap components built with Vue.js
http://yuche.github.io/vue-strap/
MIT License
4.71k stars 932 forks source link

Popover fixes #414

Open eloiqs opened 7 years ago

eloiqs commented 7 years ago

Good day!

I was trying to use this package in my project for some quick feature I needed to implement and came across a bug so I decided to fix it myself as I'm pretty limited in time.

The first bug was that v-if="show" was not removing the component from the dom. Wrapping the v-if logic in an outer div fixed that.

The second bug started happening after the first fix: upon triggering the popover, there would be some small amount of time where the popover appeared at the original location. To fix that I replaced the setTimeout call with Vue's own nextTick. That seemed to do the trick.

Please feel free to test this more extensively and merge or not. As I've said, I needed this for my personal use, and thought I might as well submit a PR in case you come across similar issues. I'm linking my project's vue-strap dependency to my own branch in the meantime.

Thank you!

danikristiansen commented 7 years ago

nice work, only issue was the outer div that caused issues with other components, change the div to a span and works perfect

tyhyly commented 7 years ago

with new issues,

TypeError: Cannot read property 'offsetHeight' of undefined,

this issue is triggered when i use palcement='right', but when use placement='top', it is ok.