search

yuche / vue-strap

Bootstrap components built with Vue.js
http://yuche.github.io/vue-strap/
MIT License
4.71k stars 935 forks source link

migrating vue-strap to use vue v2 #480

Closed EazyServer closed 7 years ago

EazyServer commented 7 years ago

Migrated this package to use Vue2. Would you kindly accept this PR and create new release from it. Many thanks

shaoxiong789 commented 7 years ago

In version 2.0 there is no ‘ready’ hook

sburnicki commented 7 years ago

@yuche This PR would be really helpful!

ptrace commented 7 years ago

Unfortunately, I've tested it out and it's far from working. e.g Typeahead is completely broken, [Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "value"

or using key as a name for a prop.

EazyServer commented 7 years ago

Yes, some Modules require a complete re-write to stop mutating props! such as Modal and Typeahead! but I get these errors (plus Vue2 compatibility errors) on the current stable version anyway!

shaoxiong789 commented 7 years ago

https://github.com/yuche/vue-strap/tree/v2 This is v2 upgrade version

buccfer commented 7 years ago

Any update on this?

neilsmind commented 7 years ago

Per @shaoxiong789 message above, I think this pull request should be closed.