bugfix org-timer import, when not using org-ref

yuchen-lea / org-media-note

Taking interactive notes when watching videos or listening to audios in org-mode.

GNU General Public License v3.0

243 stars 35 forks source link

bugfix org-timer import, when not using org-ref #47

Closed pedro-nonfree closed 10 months ago

pedro-nonfree commented 10 months ago

fixes #46

proposed a default media-type to be video, which in terms of UX it is better than nil for a link
org-media-note-get-media-file-by-key function is only defined when org-ref is enabled. Hence, moved after the conditional
when no org-ref, no alternative file link, that is nil, so put the filename which mpv already has open and trigger error if fails
proposed an additional process to save chars in the link

pedro-nonfree commented 10 months ago

Following #45 discussion, here, a part of fixing #46, I am proposing that the media type by default is "video". That makes at least a link that works

pedro-nonfree commented 10 months ago

I included another optimization to save chars in the link:

proposed an additional process to save chars in the link

yuchen-lea commented 10 months ago

Thank you for your contribution. Based on your work, I have made some modifications to better support org-ref.

Additionally, for the filename, I used the existing function org-media-note--format-file-path, which supports various abbreviation formats, ref variable org-link-file-path-type.