search

yuchen-lea / org-media-note

Taking interactive notes when watching videos or listening to audios in org-mode.
GNU General Public License v3.0
242 stars 35 forks source link

I get a warning about org-attach-dir #9

Closed japhir closed 3 years ago

japhir commented 3 years ago 
Symbol’s function definition is void: org-attach-dir

when I call org-media-note-hydra/body and then o

alienzj commented 3 years ago

I also got a warning like this.

yuchen-lea commented 3 years ago

That's because org-attach is not required before.

I use another way to declare the org-attach-dir function now, have a try ;)

If it still doesn't work, please let me know.

P.S. you can use (require 'org-attach) to temporally fix it.

alienzj commented 3 years ago

(require 'org-attach) can work. Thanks ~

yuchen-lea commented 3 years ago

(require 'org-attach) definitely work. However, I don't want to require the whole since I only use org-attach-dir.

I wonder, does the newest commit fix the warning?

japhir commented 3 years ago

I just updated and I do see the new mpv functions, so it looks like updating worked. I still get the error however. I found out that I didn't upgrade correctly. Trying again now!