yucheng11122017 / pe

0 stars 0 forks source link

Having multiple indexes for edit command returns a vague help message. #2

Open yucheng11122017 opened 2 years ago

yucheng11122017 commented 2 years ago

Steps to reproduce: type edit 1 3 t/friends Expected: Message like too many index image.png

soc-pe-bot commented 2 years ago

Team's Response

Likewise to #1174, INDEX field does not have the ellipses (...) after it, and the command edit 1 3 t/friends does not conform with the command format. The expected error message is thrown here.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Pin 1 2 the first input is not ignored

It was stated that the second input will be taken and the first ignored but it seems unable to handle this command. Expected: pin 2 Actual: error image.png

image.png


[original: nus-cs2103-AY2122S1/pe-interim#1134] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

According to the SociaLite User Guide, only fields with ellipses can accept multiple inputs. However, since the format for pin command is pin INDEX, SociaLite will only accept one index for the given command. The same idea is likewise applicable to delete, picture and share command.

截圖 2021-11-13 下午4.06.18.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Disagree that it is the same issue because the other issue is about it not working when it is supposed to work. This is about it not working, which is correct, but having a bad error message.


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Yeah it is an invalid command format but the error message given for this is really vague. It might have been an invalid field given Eg. h/ or invalid input for fields. Hence, there is no feedback on the exact error that is triggering this: the fact that there is more than 1 index.