yucongkoo / pe

0 stars 0 forks source link

Adding same tag with different case allowed #12

Open yucongkoo opened 11 months ago

yucongkoo commented 11 months ago

The current behaviour of tags is as follow:

Hence, I believe that your intention is that tags should not have duplicates, and they are non case-sensitive, which aligns with the normal view on tags.

However, users are allowed to add two tags as follows:

addTag 1 t/friend t/Friend

Where there will now be duplicate tags in the same client.

soc-se-bot commented 11 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

No case check for tags (It is Adding a friend tag in small letters and adding a friend tag like this (Friend))

  • It is only checking duplicates in lower case when given this command addTag 1 t/friend it adds a friend tag
  • However, when given addTag 1 t/Friend it adds a tag named Friend again.

image.png


[original: nus-cs2103-AY2324S1/pe-interim#6001] [original labels: type.FeatureFlaw severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

There are certain cases where the same characters with different capitalisation have different use cases

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]