yucongkoo / pe

0 stars 0 forks source link

Adding duplicate names allowed if the names had different case sensitiveness #4

Open yucongkoo opened 11 months ago

yucongkoo commented 11 months ago

Steps to reproduce: Add two entries with the same name but with different cases, an example is as follows:

Result: The command executes successfully and both entries are added into the application.

Screenshot 2023-11-17 at 4.23.27 PM.png

Problematic behaviour:

The application has duplicate entry detections where they will disallow duplicate entries(entries with same names), Betsy Crowe and Betsy Crowe (with 2 spaces) is generally considered to be the same name, and hence should be detected as duplicate entries.

soc-se-bot commented 11 months ago

Team's Response

There might be a possibility that Betsy Crowe and BeTsy Crowe are 2 different people.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I think it is useful to quote the following section about duplicate detection from the course website: Screenshot 2023-11-21 at 2.56.07 PM.png

Here is my stance on why I think that this should not be NotInScope:

Screenshot 2023-11-21 at 2.48.05 PM.png

On top of all the above arguments, I reported another bug that was regarding the case sensitiveness of tag, also related to duplicate detection, the bug can be found here. Despite that they did not mention that tags should be unique, they accepted the above bug, but decided to classify this particular bug as NotInScope? So from the developer's team perspective, does this mean that tag duplicate handling is more significant and important than name duplicate handling, even though the did not mentioned that tags should be unique? I find this contradicting and makes me even more harder to accept this as a NotInScope.

A side note regarding bug type: After spending more time reconsidering, I now think that this bug is considered a FeatureFlaw rather than a FunctionalityBug(that was originally reported), but the testers did not change the bug type, hence I am stating my change of decision here.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Quoting the definition of different severity levels from the course website: ![Screenshot 2023-11-21 at 3.03.18 PM.png](https://raw.githubusercontent.com/yucongkoo/pe/main/files/a3096d2f-ccc6-411d-9664-c2ecbc1cee41.png) I do not think that this flaw will be occured only in **very rare** situations, rather, it is relatively easy to have different capitalisation when typing names, such as `Ryan` and `ryan` are often two ways to type the same name, which is quite common. Hence, I think it is more suitable for this flaw to fall under as an "occasional inconvenience" to the users, as they might be able to realise that they accidentally entered the same name and correct it by removing one of the entries(if the time of realising the duplicate name and time of entering the duplicate name is not separated too far away).