search

yucongkoo / pe

0 stars 0 forks source link

Find command is less user friendly, due to OR search #6

Open yucongkoo opened 11 months ago

yucongkoo commented 11 months ago

The current implementation of the find command is using OR searches, as stated in the UG:

Clients matching at least one keyword will be returned (i.e. OR search). e.g. Hans Bo will return Hans Gruber , Bo Yang

However, this behaviour will cause the find command to be less user friendly, as they might want to specifically search for a client that has both the word Hans and Bo in their name. In the case where there are many clients in the application, and possibly a lot of clients with Hans and Bo in their name separately, the user might have to spend more time finding the specific customer, since there is no way for users to find a name using its actual full name(i.e. more than one word)

nus-se-script commented 11 months ago

Team's Response

We did not intend for AND search but rather OR search

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: > We did not intend for AND search but rather OR search

This just proves that this bug is not a functionality bug, I categorised this as a feature flaw though.

The dev team did not provide any justifications on why they think this flaw is NotInScope, even though I already stated the problematic behaviour in the original report. From my point of view, this flaw should not actually be NotInScope.

I think it is worth bring up the product scope and value proposition of the product when discussing this bug:

The following is extracted from the dev teams' DG product scope section(Note that this is the full image of the product scope section, nothing is omitted from the diagram):

Screenshot 2023-11-21 at 3.22.45 PM.png

As we can see from the highlighted sentences, one of the main value propositions of this product is the ability to easily and effectively find clients' information. On top of that, they also mentioned that their target users only remember certain parts of their clients' name(i.e. first name, last name etc), which would imply that their target users are not very good at remembering names. If they sometimes can only remember the first name, there is a high possibility that they can't even remember/ remember wrong the whole first name from my point of view.

After understanding the background context and product scope, I think that the find feature should be as of one of the highest priority feature and should be carefully designed and considered.

I am not fully rejecting the current OR search feature as I do think that it has its benefits too, but I think that an AND search would make the find feature able to include both OR and AND search functionality(the user can simply just use two different find commands to search for a single word to perform the OR search), but there is no way for the user to perform an AND search using the current OR search implementation.

On top of that, I am not very sure why the team actually chose OR search over AND search(nothing was mentioned in the DG too, and nothing was mentioned in their response to this bug too). Hence, I am not very convinced on why this is NotInScope.