# Sample State: - Githubissues

yudagn / AetherBnB

AetherBnb is a clone of the website Airbnb that implements many of the features available on Airbnb.

0 stars 0 forks source link

# Sample State: #4

Open Evan-Leon opened 2 years ago

Evan-Leon commented 2 years ago

[x] State shape is flat!
[x] State’s keys are camelCased
[x] All keys within the values in the state are accessible in the schema
[x] Correctly formatted
- [x] Sample state is rendered with triple backticks, and the language javascript...). This will display the state as a code block instead of a giant line of text
- [x] Top level slices
  - [x] entities
  - [x] session
  - [x] errors (here or in ui)
  - [x] ui (if needed)
- [x] Should NOT have nested slices, aka comments inside of posts
  - Some info from other tables is ok, for instance:
    - the author username and imageurl for a post. basically any info that the user can’t change
    - like count and a boolean on whether the user likes the post instead of a likes slice

Evan-Leon commented 2 years ago

beware of nesting in entities, reviews should have its own slice of state, and any references to reviews in other entities should be an array of ids

yudagn commented 2 years ago

I was planning on not having a jbuilder for reviews, because the only time youll see reviews is on a listing page or the users show page, so i thought it would be best to just make one call to the backend and bring up the users reviews with the user, and the listings reviews with the listing. Should I not do that?

On Wed, Oct 27, 2021 at 10:39 AM Evan Leon @.***> wrote:

beware of nesting in entities, reviews should have its own slice of state, and any references to reviews in other entities should be an array of ids

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yudagn/AetherBnB/issues/4#issuecomment-952997276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUE7RR7IAJOOLC4C5SWM2GTUJAFJNANCNFSM5G2Q2H5Q .

Evan-Leon commented 2 years ago

You should definitely do that. Exactly, we should make one call to like the listing show page, that would bring back with it, in the jbuilder response, 3 objects (listings, reviews, bookings?) which we would put as our action payload, and the necessary reducers would handle each slice.

With this we will likely want an array of reviewIds, for reference in our user (if you like, probably not necessary) and listing (probably more necessary), the tea_time demo from the jbuilder lecture has a pretty good example of this workflow