yudai-nkt / jupyterlab_city-lights-theme

A port of the City Lights theme for JupyterLab
https://www.npmjs.com/package/@yudai-nkt/jupyterlab_city-lights-theme
MIT License
56 stars 3 forks source link

Can you make it into a `prebuilt extension`? #158

Open hellojinwoo opened 3 years ago

hellojinwoo commented 3 years ago

The installation of source extensions jupyter labextension install is likely to be removed in future versions of JupyterLab: jupyterlab/jupyterlab#11336 . So the only way to install your theme would be a 'prebuilt extension'. Can you make your theme jupyterlab_city-lights-theme a prebuilt extension, please?

More information on a prebuilt extension can be found here

I would love to install your theme on jupyterlab desktop, but only prebuilt extensions are allowed to be installed there. So please make your city lights theme to the prebuilt extension.

jtpio commented 3 years ago

Hi,

Coming here from the issue on JupyterLab: https://github.com/jupyterlab/jupyterlab/issues/11336

Although it's not decided if or when the managing of source extensions will be dropped, installing prebuilt extensions is still a nice improvement for the end users.

There is also a migration guide in the docs, and the python -m jupyterlab.upgrade_extension script should already help quite a bit with the migration: https://jupyterlab.readthedocs.io/en/stable/extension/extension_migration.html#jupyterlab-2-x-to-3-x

yudai-nkt commented 3 years ago

I once tried to support the prebuilt extension when JupyterLab 3.0 came out, and #100 is an attempt to prepare Python's venv setup prior to the actual implementation. As you can see in the PR, GitHub Actions somehow keeps failing in the topic branch whereas the equivalent test goes well on my local end. I gave up troubleshooting quite a while ago, but I try to make some time again to look into this.

I didn't know that jupyterlab/jupyterlab#11336 has been discussed. Thanks for letting me know!

hellojinwoo commented 3 years ago

For some applications, the only allowed way to install jupyter extensions is via 'pip' or 'conda' already. So the command jupytelab extension install does not work. One of the examples is the 'Jupyterlab Desktop'.

So hope this theme would be migrated to the prebuilt extensions successfully!