search

yudai / cf_nise_installer

Cloud Foundry v2 installer with Nise BOSH and Vagrant
Apache License 2.0
84 stars 57 forks source link

template fixes #138

Closed tchughesiv closed 9 years ago

tchughesiv commented 9 years ago
yudai commented 9 years ago

Hi @tchughesiv, thank you for the PR. Could you explain the intention of these changes? And please squash the commits by logical changes.

tchughesiv commented 9 years ago

Sure, the logging_level addition allows one to change level from the default debug2. the uaa authority additions/changes fix errors around service access for things like user permission changes in orgs/spaces and gorouter access for certain tasks. additionally, the admin user was missing a few necessary rights. setting enable_routing_api to false to merely to disable the new cf incubation routing_api for diego tasks. It causes errors unless diego is fully functional. the default setting used to be false, but changed to "true" in v213. nise_installer wasn't working with diego for me and i was getting a lot of errors so figured it should be disabled until ready. Thoughts?

Also, what do you mean by "please squash the commits by logical changes".

yudai commented 9 years ago

Thanks.

As for the logging_level, I think debug2 is better than info. Because this repo is intended for development environment.

The UAA authority changes and the routing variable sound good to merge :+1: (I've not tried diego yet. Perhaps try to introduce in the future)

Right now, this PR has 6 commits, however, we have actually only two logical changes (for UAA and routing, at lease). To make the commit log clean and easy to read, you can rewrite your commits using git rebase. Please also update the commit messages so that others can see what's the contents of the commits from the messages. https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits