search

yudai / gojsondiff

Go JSON Diff
Other
536 stars 79 forks source link

Show null instead of nil by ascii formatter #8

Closed haya14busa closed 7 years ago

haya14busa commented 7 years ago

@yudai

Ascii formatter outputs <nil> for null value, but it should be null because it's JSON after all. I also added tests.

Please check. Thanks in advance!

haya14busa commented 7 years ago

Note that this pull-request includes commit in #7 to run test. I'll rebase it if you want when #7 is merged.

yudai commented 7 years ago

Thanks. Could you rebase this PR on the master?

haya14busa commented 7 years ago

Thanks! rebase done.

yudai commented 7 years ago

Thanks!

haya14busa commented 7 years ago

Thank you for the prompt response! :+1: