yudaprawira / timthumb

Automatically exported from code.google.com/p/timthumb
0 stars 0 forks source link

Remote cache files are not refreshed when a file changes #148

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. link to a remote image on flickr using 
timthubm.php?src=http://yoursite.com/splash.jpg
2. upload a new version of http://yoursite.com/splash.jpg
3. timthubm.php?src=http://yoursite.com/splash.jpg will continue to show the 
original image from cache

What is the expected output? What do you see instead?
I would expect that timthubm.php?src=http://yoursite.com/splash.jpg would 
notice that there's a new version of the file and create a new cache image to 
display

What version of the product are you using? On what operating system?
1.19, OSX Server 10.6

Please provide any additional information below.
I don't think that the curled file is being checked for last modified and so 
the cache is never refreshed once the file is retrieved the first time...

Original issue reported on code.google.com by shaun.gi...@gmail.com on 19 Jan 2011 at 9:34

GoogleCodeExporter commented 8 years ago
the external request is done as little as possible.

If you were to make an external request on every image load it would be both 
slow for your web server (contacting external website), slow for the external 
server (increased server requests), and slow for the user (more stuff to do so 
longer to wait).

As such I don't think there's anything I can do to fix this.

Original comment by BinaryMoon on 11 Jun 2011 at 9:04

GoogleCodeExporter commented 8 years ago
Do you meant that they will do like this:

http://localhost/themetest/wp-content/themes/charmer/scripts/timthumb.php?src=ht
tp://blogger.com.hacker.com/attack.php

Then will cache attack.php in cache folder, right? i tested with my site but 
not right.

Original comment by blogaf...@gmail.com on 2 Aug 2011 at 8:08

GoogleCodeExporter commented 8 years ago
That's a different issue than I was reporting here.  You should probably report 
that as it's own issue. 

Original comment by sgil...@farviewsoft.com on 3 Aug 2011 at 10:19