Invalid module code treated as valid for module_search

[yuechen2001]

Steps to reproduce:

1. Run the command "module_search m/CS21009"

Expected: Invalid module code Actual: List of students with module: CS21009 0 students listed!

Hi! I think the dev team did a good job filtering out invalid module codes when implementing the add_module function. However, there is this one feature flaw for the module_search function

• I entered an invalid module code, however instead of telling me that it is an invalid module code, the command passed through successfully and listed 0 students (which is expected behaviour).
• This might be confusing to the user who might keep trying the same module code, not knowing that the module code entered in fact is invalid.
• My suggestion would be to add validation checks to this command.

[nus-se-bot]

Team's Response

Noted on the issue. The command works as expected and does not cause any issue for users. It would be nice for it to warn the user, but since the operation is not destructive in any way, it is not an essential feature

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [x] I disagree

Reason for disagreement: I acknowledge that the feature in question may result in minor inconveniences for users, such as having to retype commands multiple times before realizing their mistake. While these inconveniences may not significantly impact the overall usability of the product, they can still detract from the user experience and contribute to frustration, hence I've assigned it a severity of low according to the guide given in the website:

Furthermore, suppose checks are already in place for adding a module. In that case, extending these checks to cover the relevant functionality should not require significant effort and prevent users from encountering errors or making mistakes. By implementing checks and providing clear feedback to users when errors occur, we can enhance the usability of the product and improve the overall user experience.

---