search

yuenm18 / ooxml-viewer-vscode

An OOXML Viewer for Visual Studio Code
MIT License
64 stars 10 forks source link

Fix error when adding icon to deleted files and add missing stub to test #10

Closed mikeebowen closed 3 years ago

mikeebowen commented 3 years ago

This commit adds a check for cachedFileExists.length in addition to cachedFileExists, because since file is set as an empty Uint8Array it will always be true, so we need to check for length as well. This caused the issue that when a file was marked as deleted, it wouldn't be removed when more changes were made and would never be cleared from the tree view.

This commit also adds a stub for workspace.fs.readFile to fix a failing test.

mikeebowen commented 3 years ago

My team is going to start promoting this extension at our events in the next few months, so I'm expecting more issues/bugs to be created on this repo. Could you add me as a collaborator with a Maintain role. I don't need to Write, but it would be helpful if I can respond to issues and bugs.

Thanks!

yuenm18 commented 3 years ago

Thanks, you should be a collborator now