search

yuezk / github-account-switcher

A convenient extension that enables users to seamlessly switch between multiple GitHub accounts.
MIT License
71 stars 6 forks source link

when using account switcher it breaks Actions live logs #8

Open AllinolCP opened 1 year ago

jakenvac commented 12 months ago

I've done some debugging on this and I think it's because the __account__ query param gets injected into the url that establishes the websocket connection for logs.

jakenvac commented 12 months ago

I have "fixed" this locally. There's some code that overrides the browsers fetch behavior to append the __account__ parameter to all urls. I couldn't see what this was used for aside from forcing an account switch. The logic that handles the auto switch rules also checks for this query - I'm assuming for manual overrides/debugging.

Stripping out all of logic around __account__ and removing the fetch override restores the log behavior and it doesn't seem to have broken anything.

I'll raise a PR but I'm anticipating that the code I've removed was indeed there for a reason.