yufenhsi / MI-449-SS18-740-css-sass-intro-8dVLYn

0 stars 0 forks source link

Project Feedback #1

Open yufenhsi opened 6 years ago

yufenhsi commented 6 years ago

Create a Sassy component library

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

egillespie commented 6 years ago

Wow, your site looks very pretty, @yufenhsi! Coolors generated some very pleasant colors for you. Not only that, but your components look very clean, consistent, and the code is organized very well, too! 😍

I have one request to improve on what you've got:

Move variables into their own file

Would you mind moving your Sass variables into their own file using the techniques outlined in this lesson? That will satisfy requirement 7 and be a nice finishing touch for this project!

Thanks! 🚀

yufenhsi commented 6 years ago

Hi Erik,

I've move variables into _variables.scss file and put @import "_variables" in the style file. Thank you!

egillespie commented 6 years ago

Awesome, that change looks great! 💯 :shipit: