Project Feedback

[yufenhsi]

Build a simple website for an imaginary, local store that sells geeky T-shirts

@KatieMFritz Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Include a homepage and at least one other page, for your best-selling T-shirt (you can download a T-shirt image from ThinkGeek)
• [x] A language is specified for the website (it does not have to be in English!)
• [x] A title and meta name="description" are provided for each page
• [x] Every page includes a link to a favicon.ico file with the company logo (you can create one here or design one yourself)
• [x] Location information is provided on every page (you can place the store anywhere in the world, as long as there's an existing building there)
• [x] When each page is shared on Facebook and Twitter, a beautiful card is generated (and the respective validators should return no errors/warnings -- though you can ignore the The following required properties are missing: fb:app_id warning for Facebook)

[KatieMFritz]

Yufen, you did an awesome job with this! 🎉 👕 🔥 Your pages look nice, and you've addressed all the requirements! Way to go! 💥 💪 😸

Some ways to improve:

Address Facebook validator warnings

I see 3 warnings for your homepage and one for your tshirt page.

Use unique titles for your sharing tags

You've done an excellent job showing the two pages are different with the descriptions, featured images, and title elements. 👍

However, both of your pages are called "Parade of Fans for Comics" when I share them on Facebook and Twitter. Could you please make it clear from the titles that they are different pages? 👕

Fix navigation links

Because Github pages is annoying, you have to use relative links. Your navigation bar links don't work currently. Could you please change them so they work? Here's the lesson page where you learned about relative links. 🚀

Use unique, descriptive commit messages

You've used almost the same commit message for all three commits. Commit messages should describe what is changing between each commit. So for example, you could say "change og:title, update links, add og:image property". Please use unique, descriptive commit messages going forward!

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! :rocket:

[yufenhsi]

Hi Katie,

Thank you for checking my project and giving the suggestions. I can learn more and understand what I missed every time because of the proces of following the suggestions to correct those issues. I've fixed Facebook validator warnings and used relative links in navs. The navigation links can work currently. I also changed a title-"Distinctive Animation Clothing" for the tshirt page and changed both "og:description" for my homepage and tshirt page.

[KatieMFritz]

😁 I'm so glad you are learning and understanding more! I see your work getting better and better too. ✨

1. Great job with the Facebook sharing. 👍
2. Nice unique titles. 🎉
3. Navigation links work now, but take me to the index.html versions of the URLs. Would you mind updating the links so they don't include that? If you need a refresher, look back on the "building a website with multiple pages" lesson. 🔗
4. Your latest commit message is more descriptive, but you used it three times in a row. How can I tell what's different between those three commits? Please try to be a little more specific. ✏️

Twitter preview isn't displaying any text

When I look at your pages now in the Twitter card validator, there are no errors, but I also only see an image - no title or description. It was working before, and I don't see any problems from looking at your code, so it's weird. 😕 Here are some troubleshooting ideas:

• Do you see the same thing (just an image) when you look at your URLs in the Twitter validator?
• What happens if you take out <meta property="fb:app_id" content="1678641972181977"/>?
• What happens if you change the twitter:card value to summary instead of summary_large_image?

[yufenhsi]

Hi Katie,

I commited two commit messages for this revision The former:

1. I've removed the index.html on Navigation links and checked the links both on general and live-server situation.

I saw the same thing(just an image) as you did, so I added meta.

2. Add same twitter:title and twitter:descriptions for both my homepage and tshirt page
3. change twitter:card value to summary instead of summary_large_image After I add twitter:title and twitter:descriptions, I can see the descriptions not just an image. If I take out , there was an error shown in Facebook validator.

The later:

4. I found I used same twitter:title and twitter:descriptions for different pages, so I changed twitter:title on tshirt page and twitter:description on homepage.

Thank you!

[KatieMFritz]

Your latest two commit messages are SO GOOD. 😍 Keep writing them just like that! 🎉

Nice job fixing the Twitter display issue! 💪 Everything looks good to me now. :shipit: