search

yufuquant / rust-bybit

Rust API connector for Bybit's WebSockets APIs.
MIT License
34 stars 10 forks source link

Working on Futures rest_api for historical_trades over the weekend. #3

Open inconspicuous99 opened 2 years ago

inconspicuous99 commented 2 years ago

^ Will build off of the linear branch.

inconspicuous99 commented 2 years ago

https://github.com/Igosuki/binance-rs-async/blob/master/src/client.rs https://github.com/Igosuki/binance-rs-async/blob/master/src/api.rs https://github.com/Igosuki/binance-rs-async/blob/master/src/config.rs

^ thoughts on using a similar structure for authentication?

IE specifically, shared client that signs stuff for whatever is received, and test/mainnet urls can be pulled from default config or passed in through custom config.

inconspicuous99 commented 2 years ago

yo @traderlabs @sbusso wanna work with us on this instead of your binance fork: https://github.com/traderlabs/bybit-rs

inconspicuous99 commented 2 years ago

also can we have async built in, PLEASE.

Idk how to create a project with async & sync at the same time though.

inconspicuous99 commented 2 years ago

also can we have async built in, PLEASE.

Idk how to create a project with async & sync at the same time though.

Ok I'm fine not doing, will probably be slower & can just use threads.

jukanntenn commented 2 years ago

Welcome!

^ Will build off of the linear branch.

linear branch is for USDT-M WebSocket client. The job will finish soon and this branch will be merged to main. Please create feature branch from main.

also can we have async built in, PLEASE.

Idk how to create a project with async & sync at the same time though.

This feature will be considered in a later version, but can not promise any priority. I focus on implementing all WebSocket&Restful API clients which are in a synchronized fashion for now.

inconspicuous99 commented 2 years ago

kk, nw.

I got behind on work, have to catch up on that for now. But when I start working, what folder should I use for linear_rest api?

linear_rest folder and linear_ws? My brain always goes to: linear

jukanntenn commented 2 years ago

I suggest this structure:

spot/
    ws.rs
    rest.rs
linear/
    ws.rs
    rest.rs