There are some related problems we are tracking here:
We do not have a cleaner way to set Gflags and start yugabyted inside the container. If we have to change/add one GFlag, we may need to make additional modifications to the test, for example, in YugabyteDBTabletSplitTest
Some tests are flaky and are not modified according to the consistent snapshot behaviour, as a result they end up failing at the assertion stages where we verify the count.
Solution
This PR fixes the flakiness behaviour of the tests as well as introduces methods in the TestBaseClass i.e. setMasterFlags and setTserverFlags which will help simplify the process.
Usage
The methods are to be used before the initializeYBContainer() method and if the container is started separately in the test then the flags need to be set before obtaining the container. For example:
Inside beforeAll method
public static void beforeAll() {
setMasterFlags(masterFlags);
setTserverFlags(tserverFlags);
initializeYBContainer();
}
Before obtaining the container
// test code
setMasterFlags(masterFlags);
setTserverFlags(tserverFlags);
ybContainer = TestHelper.getYbContainer();
// further test code
Problem
There are some related problems we are tracking here:
yugabyted
inside the container. If we have to change/add one GFlag, we may need to make additional modifications to the test, for example, inYugabyteDBTabletSplitTest
Solution
This PR fixes the flakiness behaviour of the tests as well as introduces methods in the
TestBaseClass
i.e.setMasterFlags
andsetTserverFlags
which will help simplify the process.Usage
The methods are to be used before the
initializeYBContainer()
method and if the container is started separately in the test then the flags need to be set before obtaining the container. For example: