search

yugabyte / homebrew-tap

brew formula for yugabyte
Apache License 2.0
5 stars 6 forks source link

updated depends_on for Java to use OpenJDK (:java was failing) #17

Closed thtmnisamnstr closed 3 years ago

thtmnisamnstr commented 3 years ago

Running brew tap yugabyte/yugabytedb fails. I updated the depends_on :java dependiencies in your Homebrew tap to depends_on "openjdk", as the depends_on :java dependencies are no longer valid.

Terminal Output before PR

==> Tapping yugabyte/yugabytedb
Cloning into '/usr/local/Homebrew/Library/Taps/yugabyte/homebrew-yugabytedb'...
remote: Enumerating objects: 151, done.
remote: Counting objects: 100% (43/43), done.
remote: Compressing objects: 100% (32/32), done.
remote: Total 151 (delta 12), reused 35 (delta 9), pack-reused 108
Receiving objects: 100% (151/151), 36.17 KiB | 1.21 MiB/s, done.
Resolving deltas: 100% (38/38), done.
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/yugabyte/homebrew-yugabytedb/Formula/yugabytedb.rb
yugabytedb: Unsupported special dependency :java
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/yugabyte/homebrew-yugabytedb/Formula/yugabytedb-client.rb
yugabytedb-client: Unsupported special dependency :java
Error: Cannot tap yugabyte/yugabytedb: invalid syntax in tap!
bhavin192 commented 3 years ago

Other references related to this issue:

thtmnisamnstr commented 3 years ago

@bhavin192 I updated both formula to use “openjdk@8”.