Change to use actual port corresponding to the server chosen for connection - Githubissues

yugabyte / jdbc-yugabytedb

JDBC Driver for Yugabyte SQL (YSQL)

BSD 2-Clause "Simplified" License

17 stars 7 forks source link

Change to use actual port corresponding to the server chosen for connection #8

Closed kneeraj closed 3 years ago

kneeraj commented 3 years ago

The driver was assuming same port for all the servers, which may not be true in all cases.

All Submissions:

[✅ ] Have you followed the guidelines in our Contributing document?
[✅ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[✅] Does your submission pass tests?
[✅] Does mvn checkstyle:check pass ?
[ ✅] Have you added your new test classes to an existing test suite? Added on the product side.

Changes to Existing Features:

[ ] Does this break existing behaviour? If so please explain.
[✅] Have you added an explanation of what your changes do and why you'd like us to include them?
[✅ ] Have you written new tests for your core changes, as applicable?
[✅ ] Have you successfully run tests with your changes locally?

kneeraj commented 3 years ago

LGTM. It would be great if we can update the variable name pubHostPortMap to more descriptive one.

OK. Will do.