Closed sonalsagarwal closed 3 years ago
@sonalsagarwal can you quickly reference some results in the commit message to motivate this change? otherwise, if you can remove the commented code, rest looks good to me
Some numbers with changes and no changes.
No Change in tpcc branch : 04:31:06,209 (DBWorkload.java:510) INFO - ================RESULTS================ TPM-C | 25004.17 Efficiency | 97.22% Throughput (req/s) | 934.09
04:31:06,882 (DBWorkload.java:544) INFO - ================LATENCIES=============== Operation | Avg. Latency | P99 Latency | Connection Acq Latency NewOrder | 54.22 | 391.10 | 38.38 Payment | 32.94 | 160.80 | 60.50 OrderStatus | 17.29 | 131.00 | 69.73 Delivery | 168.79 | 1123.84 | 67.71 StockLevel | 72.52 | 391.49 | 72.50
Splitting delivery transaction :: Run 1 : ================RESULTS================ TPM-C | 24992.93 Efficiency | 97.17% Throughput (req/s) | 933.87
05:25:24,729 (DBWorkload.java:544) INFO - ================LATENCIES=============== Operation | Avg. Latency | P99 Latency | Connection Acq Latency NewOrder | 50.09 | 391.58 | 35.58 Payment | 30.16 | 177.57 | 63.45 OrderStatus | 17.29 | 124.63 | 77.90 Delivery | 170.24 | 1224.84 | 74.91 StockLevel | 68.42 | 385.26 | 75.89
Run 2 : ================RESULTS================ TPM-C | 24993.10 Efficiency | 97.17% Throughput (req/s) | 934.20
07:37:38,358 (DBWorkload.java:544) INFO - ================LATENCIES=============== Operation | Avg. Latency | P99 Latency | Connection Acq Latency NewOrder | 51.46 | 379.54 | 38.19 Payment | 31.31 | 167.32 | 64.03 OrderStatus | 16.75 | 107.28 | 77.23 Delivery | 174.66 | 1146.46 | 75.52 StockLevel | 68.16 | 370.14 | 77.84
Run 3 : ================RESULTS================ TPM-C | 25011.70 Efficiency | 97.25% Throughput (req/s) | 933.88
07:39:24,856 (DBWorkload.java:544) INFO - ================LATENCIES=============== Operation | Avg. Latency | P99 Latency | Connection Acq Latency NewOrder | 53.05 | 375.50 | 41.05 Payment | 31.83 | 144.47 | 61.61 OrderStatus | 17.40 | 105.43 | 79.22 Delivery | 179.72 | 1076.31 | 73.93 StockLevel | 71.00 | 370.89 | 76.10
Instead of committing one transaction for 10 deliveries, commit each delivery individually.