yugabyte / yb-tools

Tools for YugabyteDB database maintenance and support
Apache License 2.0
19 stars 18 forks source link

Fixed #80 #81

Closed pgyogesh closed 1 year ago

pgyogesh commented 1 year ago

Tested with below tables and columns

CREATE TABLE t3("Id" int primary key);
CREATE TABLE t2(ID int primary key);
CREATE TABLE t1("ID" int primary key);

And it works

go run main.go k1 -c 127.0.0.2
Checking table row counts for keyspace: k1
Checking row counts for: k1.t3
Partitioning columns for k1.t3:(Id)
Performing 4096 checks for k1.t3 with 16 parallel tasks
==========
Total time: 181 ms
==========
Total Row Count k1.t3 = 1

Checking row counts for: k1.t2
Partitioning columns for k1.t2:(id)
Performing 4096 checks for k1.t2 with 16 parallel tasks
==========
Total time: 184 ms
==========
Total Row Count k1.t2 = 3

Checking row counts for: k1.t1
Partitioning columns for k1.t1:(ID)
Performing 4096 checks for k1.t1 with 16 parallel tasks
==========
Total time: 203 ms
==========
Total Row Count k1.t1 = 3
tylarb commented 1 year ago

Code changes look good.

@pgyogesh would recommend using a commit message more like

Allow capitalized and quoted table names
fixes #80 

instead of just the github issue - this allows a commit history to be viewable with context in a local git blame.