yugabyte / yb-voyager

Data migration Engine for YugabyteDB database
38 stars 10 forks source link

Addded Guardrails check for pg_stat_statements in assess migration cmd #1957

Closed sanyamsinghal closed 1 day ago

sanyamsinghal commented 1 day ago

Note: checking if pgss is properly installed or not (via shared_preload_libraries) is not possible, needs pg_read_all_settings grant to the user. Feels unnecessary to add this to our grant script just for a check. So it will best effort, if it able to fetch the libraries then we check in the list, otherwise just add warn to the logs and assess-migration command will fail at the step of db_queries_summary metadata script execution.

Cases this new guardrails check detects: image

https://yugabyte.atlassian.net/browse/DB-14108 https://yugabyte.atlassian.net/browse/DB-13678

sanyamsinghal commented 1 day ago

https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/4000/