yugabyte / yugabyte-operator

Kubernetes Operator for YugabyteDB (legacy)
65 stars 29 forks source link

Create Events when scaling down YB-TServers #19

Closed bhavin192 closed 3 years ago

bhavin192 commented 3 years ago

Creates two events, ScalingDownTServers and ScaledDownTServers. These events get displayed when kubectl describe ybcluster command is executed.

Scenarios tested

nchandrappa commented 3 years ago

@bhavin192 Code looks good. Please add a test or update test in func TestReconcile(t *testing.T) for testing the new events. Thanks.

bhavin192 commented 3 years ago

Hey @nchandrappa right now few of the tests are broken due to other changes we have made previously (using exec API). And TestReconcile is one of the broken tests. I'm planning to work on them as a separate PR as it involves more efforts. I will cover this event related change in the updated tests later.

nchandrappa commented 3 years ago

@bhavin192 okay then I'll approve the PR. Please add those tests when you get a chance. Thanks